feat: added selectId #183
Open
feat: added selectId #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rainerhahnekamp or @abhijit-chikane Can you please review this PR? |
|
If it has no bugs, it will make it also into the 19 branch. For more details: #181 |
|
@rainerhahnekamp I merged this with master to fix the merge errors, now there are new commit rules that are throwing errors due to files i have not touched that are stopping me from fixing the lint errors. |
|
@DrakeAnglin as far as I can see it is complaining exaclty about those files where you made changes. Please run prettier on them. |
rainerhahnekamp
requested changes
Aug 10, 2025
| const createFlightWithCustomId = ( | ||
| flight: Partial<FlightWithCustomId> = {} | ||
| ): FlightWithCustomId => ({ | ||
| flightId: `${++currentCustomFlightId}`, |
There was a problem hiding this comment.
let's to the conversion how it is also suggested in the Google styleguide.
Suggested change
| flightId: `${++currentCustomFlightId}`, | |
| flightId: String(++currentCustomFlightId), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #67
closes #28